Skip to content

Managing unmanaged file resource - #229

Closed
kamlane wants to merge 2 commits into
puppetlabs:mainfrom
kamlane:create_required_mount_directories
Closed

Managing unmanaged file resource#229
kamlane wants to merge 2 commits into
puppetlabs:mainfrom
kamlane:create_required_mount_directories

Conversation

@kamlane

@kamlane kamlane commented Feb 7, 2019

Copy link
Copy Markdown

The Mount resource default statement is dependent on a resource not managed by the module so it bombs out; the exec statement at the bottom of logical_volume doesn't consistently execute on puppetserver 4.10 for some reason.

…anaged by the module; the exec statement at the bottom of logical_volume doesn't consistently execute on puppetserver 4.10
@Yamakasi

Copy link
Copy Markdown

Also please accept this commit, but it might be good to add something like this:

  if $mountpath == "/$name" {
        $mountpath_final = "/${name}"
  } else {
        $mountpath_final = "${mountpath}/${name}"
  }

... replace $mountpath with $mountpath_final in the lower code.

@CLAassistant

CLAassistant commented Feb 24, 2021

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@codecov-commenter

codecov-commenter commented Jun 5, 2021

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@d621bd9). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #229   +/-   ##
=======================================
  Coverage        ?   72.96%           
=======================================
  Files           ?       17           
  Lines           ?      773           
  Branches        ?        0           
=======================================
  Hits            ?      564           
  Misses          ?      209           
  Partials        ?        0           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jst-cyr

jst-cyr commented Jun 24, 2026

Copy link
Copy Markdown
Member

@kamlane : My apologies that nobody has responded on this for so much time. I'm going through our pull requests across modules and came across this request here. Is this still an issue for you?

@jst-cyr

jst-cyr commented Jul 13, 2026

Copy link
Copy Markdown
Member

Given the age of the PR, I am cancelling this PR for now. Please re-open if this continues to be a need!

@jst-cyr jst-cyr closed this Jul 13, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants